Fix Retweet Return Information #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Twitter::Status.new(status) | ||
| new_status = post("/1/statuses/retweet/#{id}.json", options) | ||
| orig_status = new_status['retweeted_status'] | ||
| new_status.delete('retweeted_status') |
There was a problem hiding this comment.
You should be able to replace lines 134 and 135 with:
orig_status = new_status.delete('retweeted_status')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twitter.retweet should return the original status with tweet.retweeted_status returning the newly created tweet information (including the new id, so we can delete the retweet directly if the user wants). Right now, the new status information is completely removed.
The API returns the information reversed (the new status information, with 'retweeted_status' containing the original tweet information), but I figure doing that would mess up a lot of existing code